public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
	Anshu Kumari <anskuma@redhat.com>
Cc: passt-dev@passt.top, lvivier@redhat.com, jmaloy@redhat.com
Subject: Re: [PATCH 0/6] Add --dhcp-boot and --dhcp-opt options
Date: Wed, 20 May 2026 02:38:04 +0200 (CEST)	[thread overview]
Message-ID: <20260520023804.131ef7ad@elisabeth> (raw)
In-Reply-To: <agv1gV2xXZPZzUIS@zatzit>

On Tue, 19 May 2026 15:30:41 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Mon, May 18, 2026 at 06:49:56PM +0530, Anshu Kumari wrote:
> > This series adds support for custom DHCP options in passt, enabling
> > network boot (PXE/UEFI HTTP Boot) and arbitrary DHCP option injection.
> > 
> > Two new command-line flags are introduced:
> > 
> >   --dhcp-boot URL    Sets the boot file URL (DHCP option 67 and the
> >                      legacy boot file field)
> > 
> >   --dhcp-opt CODE,VALUE
> >                      Sets any DHCP option by numeric code, with
> >                      type-aware parsing per RFC 2132
> > 
> > The DHCP reply path is extended with option overload support (RFC 2132
> > option 52), allowing options to overflow into the file and sname fields
> > when the standard options area is full.
> > 
> > *** BLURB HERE ***  
> 
> Nit: remember to remove this boilerplate that git-publish inserts :)

No, no, that's from git format-patch, I swear (as somebody who doesn't
use git-publish).

Another detail, while at it: for some reason git send-email picked
the "chain-reply" style, that is, if you look at this in a threaded
email client, patch #1 is a reply to the cover letter (fine, expected)
but patch #2 is a reply to patch #1 (not expected), and so on.

That's the --chain-reply-to option for git send-email. You should
disable that (for example in gitconfig in case you have it on there)
and just use --cover-letter.

-- 
Stefano


  reply	other threads:[~2026-05-20  0:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 13:19 Anshu Kumari
2026-05-18 13:19 ` [PATCH 1/6] conf: Add --dhcp-opt command-line option Anshu Kumari
2026-05-18 13:19   ` [PATCH 2/6] conf: Add --dhcp-boot " Anshu Kumari
2026-05-18 13:19     ` [PATCH 3/6] dhcp: Add option type table and value parser Anshu Kumari
2026-05-18 13:20       ` [PATCH 4/6] dhcp: Refactor fill_one() to operate on a generic buffer Anshu Kumari
2026-05-18 13:20         ` [PATCH 5/6] dhcp: Add option overload Anshu Kumari
2026-05-18 13:20           ` [PATCH 6/6] doc: Add --dhcp-boot and --dhcp-opt to man page Anshu Kumari
2026-05-19  6:11           ` [PATCH 5/6] dhcp: Add option overload David Gibson
2026-05-19  6:02         ` [PATCH 4/6] dhcp: Refactor fill_one() to operate on a generic buffer David Gibson
2026-05-19  5:59       ` [PATCH 3/6] dhcp: Add option type table and value parser David Gibson
2026-05-20  0:39       ` Stefano Brivio
2026-05-19  5:35     ` [PATCH 2/6] conf: Add --dhcp-boot command-line option David Gibson
2026-05-19  5:33   ` [PATCH 1/6] conf: Add --dhcp-opt " David Gibson
2026-05-20  0:38   ` Stefano Brivio
2026-05-19  5:30 ` [PATCH 0/6] Add --dhcp-boot and --dhcp-opt options David Gibson
2026-05-20  0:38   ` Stefano Brivio [this message]
2026-05-20  1:31     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260520023804.131ef7ad@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=anskuma@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=jmaloy@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).