Re: [PATCH 0/6] Add --dhcp-boot and --dhcp-opt options

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]

On Wed, May 20, 2026 at 02:38:04AM +0200, Stefano Brivio wrote:
> On Tue, 19 May 2026 15:30:41 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > On Mon, May 18, 2026 at 06:49:56PM +0530, Anshu Kumari wrote:
> > > This series adds support for custom DHCP options in passt, enabling
> > > network boot (PXE/UEFI HTTP Boot) and arbitrary DHCP option injection.
> > > 
> > > Two new command-line flags are introduced:
> > > 
> > >   --dhcp-boot URL    Sets the boot file URL (DHCP option 67 and the
> > >                      legacy boot file field)
> > > 
> > >   --dhcp-opt CODE,VALUE
> > >                      Sets any DHCP option by numeric code, with
> > >                      type-aware parsing per RFC 2132
> > > 
> > > The DHCP reply path is extended with option overload support (RFC 2132
> > > option 52), allowing options to overflow into the file and sname fields
> > > when the standard options area is full.
> > > 
> > > *** BLURB HERE ***  
> > 
> > Nit: remember to remove this boilerplate that git-publish inserts :)
> 
> No, no, that's from git format-patch, I swear (as somebody who doesn't
> use git-publish).

Oh, my mistake.  Same thought applies, though.

> Another detail, while at it: for some reason git send-email picked
> the "chain-reply" style, that is, if you look at this in a threaded
> email client, patch #1 is a reply to the cover letter (fine, expected)
> but patch #2 is a reply to patch #1 (not expected), and so on.
> 
> That's the --chain-reply-to option for git send-email. You should
> disable that (for example in gitconfig in case you have it on there)
> and just use --cover-letter.
> 
> -- 
> Stefano
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]