From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Jon Maloy <jmaloy@redhat.com>
Subject: Re: [PATCH 0/2] Fix a Coverity reported socket leak
Date: Wed, 27 May 2026 13:22:15 +0200 (CEST) [thread overview]
Message-ID: <20260527132213.5a8ff221@elisabeth> (raw)
In-Reply-To: <20260513071821.3137329-1-david@gibson.dropbear.id.au>
On Wed, 13 May 2026 17:18:19 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> I got coverity working for me again, version 2026.3.0. This pointed
> out a potentially fairly nasty socket leak in tcp_listen_handler().
> Here's a series that fixes it.
>
> David Gibson (2):
> tcp, tcp_splice: Make helper for setting SO_LINGER socket option
> tcp: Don't leak sockets on error paths
Applied, sorry for the delay.
I was wondering if Jon wanted to eventually take these in a series
fixing more warnings and waited a bit (which turned out to be longer
than I thought) but 2/2 could fix some real issues and we have a report:
https://github.com/containers/podman/issues/28644
that might actually be fixed by that. I'm now asking the reporter if
they can try out this fix.
--
Stefano
next prev parent reply other threads:[~2026-05-27 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 7:18 David Gibson
2026-05-13 7:18 ` [PATCH 1/2] tcp, tcp_splice: Make helper for setting SO_LINGER socket option David Gibson
2026-05-15 0:47 ` Jon Maloy
2026-05-13 7:18 ` [PATCH 2/2] tcp: Don't leak sockets on error paths David Gibson
2026-05-13 7:23 ` [PATCH 0/2] Fix a Coverity reported socket leak Stefano Brivio
2026-05-14 1:02 ` David Gibson
2026-05-27 11:22 ` Stefano Brivio [this message]
2026-05-28 0:40 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527132213.5a8ff221@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).