From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, Jon Maloy <jmaloy@redhat.com>
Subject: Re: [PATCH 0/2] Fix a Coverity reported socket leak
Date: Thu, 14 May 2026 11:02:33 +1000 [thread overview]
Message-ID: <agUfKXC6exjXu2Oa@zatzit> (raw)
In-Reply-To: <20260513092313.285842e4@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
On Wed, May 13, 2026 at 09:23:14AM +0200, Stefano Brivio wrote:
> On Wed, 13 May 2026 17:18:19 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > I got coverity working for me again, version 2026.3.0. This pointed
> > out a potentially fairly nasty socket leak in tcp_listen_handler().
> > Here's a series that fixes it.
>
> As we discussed in the call on Monday, Jon was going to look into
> those.
Oops, sorry, I forgot.
> Cc'ing him for awareness, as maybe he doesn't need to look into those
> anymore (but I'm not sure if you already tried passing the '--security'
> switch).
Well, not this specific warning and the one I fixed by accident in the
"More caution with NONBLOCK" series". There are a bunch more. I
think they're mostly false positives, but how to evade them is not
very obvious.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-05-14 1:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 7:18 David Gibson
2026-05-13 7:18 ` [PATCH 1/2] tcp, tcp_splice: Make helper for setting SO_LINGER socket option David Gibson
2026-05-13 7:18 ` [PATCH 2/2] tcp: Don't leak sockets on error paths David Gibson
2026-05-13 7:23 ` [PATCH 0/2] Fix a Coverity reported socket leak Stefano Brivio
2026-05-14 1:02 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agUfKXC6exjXu2Oa@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).