Re: [PATCH 0/2] Fix a Coverity reported socket leak

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

On Wed, May 27, 2026 at 01:22:15PM +0200, Stefano Brivio wrote:
> On Wed, 13 May 2026 17:18:19 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > I got coverity working for me again, version 2026.3.0.  This pointed
> > out a potentially fairly nasty socket leak in tcp_listen_handler().
> > Here's a series that fixes it.
> > 
> > David Gibson (2):
> >   tcp, tcp_splice: Make helper for setting SO_LINGER socket option
> >   tcp: Don't leak sockets on error paths
> 
> Applied, sorry for the delay.
> 
> I was wondering if Jon wanted to eventually take these in a series
> fixing more warnings and waited a bit (which turned out to be longer
> than I thought) but 2/2 could fix some real issues and we have a report:
> 
>   https://github.com/containers/podman/issues/28644
> 
> that might actually be fixed by that. I'm now asking the reporter if
> they can try out this fix.

The bug I'm fixing here occurs before we allocate timerfds, so, alas,
I think it's unlikely it will fix that report.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]