From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>, passt-dev@passt.top
Subject: Re: [PATCH 6/7] doc/platform-requirements: Initialise va_list before va_start()
Date: Thu, 09 Jul 2026 18:59:42 +0200 (CEST) [thread overview]
Message-ID: <20260709185941.4a23534a@elisabeth> (raw)
In-Reply-To: <fee7223b-34e4-4cee-b2bb-5d488c059228@redhat.com>
On Thu, 9 Jul 2026 12:49:10 -0400
Jon Maloy <jmaloy@redhat.com> wrote:
> On 2026-07-08 22:40, David Gibson wrote:
> > On Wed, Jul 08, 2026 at 06:32:02PM -0400, Jon Maloy wrote:
> >> va_start() initialises the va_list, but zero-initialise it at
> >> declaration as well to make it clear the variable is not used
> >> uninitialised.
> >
> > I really dislike this approach to suppressing uninitialised variable
> > warnings. A decent tool should be able to tell that va_start()
> > initialises ap, and pre-initialising means that tool will no longer
> > warning if we accidentally deleted the va_start().
> >
> > Is there really no other way for the warning in question?
>
> TBH I dislike it too. I still decided to post it just to see the
> feedback. I cannot see any other way to get rid of this warning,
> but maybe somebody else has?
I don't think we need to get rid of any warnings here as we don't run
static checkers on the code in platform-requirements/ anyway, it's just
there as documentation, proof of concept, or test code.
--
Stefano
next prev parent reply other threads:[~2026-07-09 16:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 22:31 [PATCH 0/7] Fix issues and false positives in code coverge tool Jon Maloy
2026-07-08 22:31 ` [PATCH 1/7] passt: Initialise listening socket fds to -1 Jon Maloy
2026-07-09 2:09 ` David Gibson
2026-07-08 22:31 ` [PATCH 2/7] udp_vu: Assert iov_tail_clone() return before assigning to msg_iovlen Jon Maloy
2026-07-09 2:11 ` David Gibson
2026-07-08 22:31 ` [PATCH 3/7] tap: Assert IPv6 tail size before subtracting header length Jon Maloy
2026-07-09 2:13 ` David Gibson
2026-07-08 22:32 ` [PATCH 4/7] doc/migration: Use strncpy() for socket path and fix argv access Jon Maloy
2026-07-09 2:20 ` David Gibson
2026-07-08 22:32 ` [PATCH 5/7] doc/migration: Fix buffer type mismatch in recv() call Jon Maloy
2026-07-09 2:22 ` David Gibson
2026-07-08 22:32 ` [PATCH 6/7] doc/platform-requirements: Initialise va_list before va_start() Jon Maloy
2026-07-09 2:40 ` David Gibson
2026-07-09 16:49 ` Jon Maloy
2026-07-09 16:59 ` Stefano Brivio [this message]
2026-07-08 22:32 ` [PATCH 7/7] doc/platform-requirements: Close leaked sockets in test_close_dup() Jon Maloy
2026-07-09 2:41 ` David Gibson
2026-07-09 2:09 ` [PATCH 0/7] Fix issues and false positives in code coverge tool David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709185941.4a23534a@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).