From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Maloy <jmaloy@redhat.com>
Cc: sbrivio@redhat.com, passt-dev@passt.top
Subject: Re: [PATCH 1/7] passt: Initialise listening socket fds to -1
Date: Thu, 9 Jul 2026 12:09:41 +1000 [thread overview]
Message-ID: <ak8C5IKyhm6wwbOR@zatzit> (raw)
In-Reply-To: <20260708223203.885345-2-jmaloy@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
On Wed, Jul 08, 2026 at 06:31:57PM -0400, Jon Maloy wrote:
> fd_tap_listen, fd_control_listen, and fd_repair_listen are file
> descriptors and should be initialised to -1 rather than the implicit
> 0, consistent with the other fd fields in passt_ctx.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> passt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/passt.c b/passt.c
> index 65a07d72..4e5b9289 100644
> --- a/passt.c
> +++ b/passt.c
> @@ -65,6 +65,9 @@ char pkt_buf[PKT_BUF_BYTES] __attribute__ ((aligned(PAGE_SIZE)));
> struct ctx passt_ctx = {
> .pidfile_fd = -1,
> .fd_tap = -1,
> + .fd_tap_listen = -1,
> + .fd_control_listen = -1,
> + .fd_repair_listen = -1,
> .pasta_netns_fd = -1,
> .device_state_fd = -1,
> };
> --
> 2.52.0
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-07-09 2:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 22:31 [PATCH 0/7] Fix issues and false positives in code coverge tool Jon Maloy
2026-07-08 22:31 ` [PATCH 1/7] passt: Initialise listening socket fds to -1 Jon Maloy
2026-07-09 2:09 ` David Gibson [this message]
2026-07-08 22:31 ` [PATCH 2/7] udp_vu: Assert iov_tail_clone() return before assigning to msg_iovlen Jon Maloy
2026-07-09 2:11 ` David Gibson
2026-07-08 22:31 ` [PATCH 3/7] tap: Assert IPv6 tail size before subtracting header length Jon Maloy
2026-07-09 2:13 ` David Gibson
2026-07-08 22:32 ` [PATCH 4/7] doc/migration: Use strncpy() for socket path and fix argv access Jon Maloy
2026-07-09 2:20 ` David Gibson
2026-07-08 22:32 ` [PATCH 5/7] doc/migration: Fix buffer type mismatch in recv() call Jon Maloy
2026-07-09 2:22 ` David Gibson
2026-07-08 22:32 ` [PATCH 6/7] doc/platform-requirements: Initialise va_list before va_start() Jon Maloy
2026-07-09 2:40 ` David Gibson
2026-07-08 22:32 ` [PATCH 7/7] doc/platform-requirements: Close leaked sockets in test_close_dup() Jon Maloy
2026-07-09 2:41 ` David Gibson
2026-07-09 2:09 ` [PATCH 0/7] Fix issues and false positives in code coverge tool David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak8C5IKyhm6wwbOR@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).