Re: [PATCH 0/7] Fix issues and false positives in code coverge tool

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

On Wed, Jul 08, 2026 at 06:31:56PM -0400, Jon Maloy wrote:
> This series fixes minor issues found by code coverage tools in the
> main passt code and in documentation examples.

Nit: If you're talking about the tool I think you are, it's not really
a "code coverage" tool.  Static anlaysis, sure, but "coverage" implies
it's about measuring the amount of the codebase tested in some way.

> The core code changes addresses missing fd initialisations and
> explicit invariant checks for unsigned arithmetic.
> 
> We also fix address buffer handling, type mismatches, uninitialised
> variables, and resource leaks in the documentation example code.
> 
> Jon Maloy (7):
>   passt: Initialise listening socket fds to -1
>   udp_vu: Assert iov_tail_clone() return before assigning to msg_iovlen
>   tap: Assert IPv6 tail size before subtracting header length
>   doc/migration: Use strncpy() for socket path and fix argv access
>   doc/migration: Fix buffer type mismatch in recv() call
>   doc/platform-requirements: Initialise va_list before va_start()
>   doc/platform-requirements: Close leaked sockets in test_close_dup()
> 
>  doc/migration/source.c                    |  2 +-
>  doc/migration/target.c                    | 10 ++++------
>  doc/platform-requirements/common.h        |  2 +-
>  doc/platform-requirements/udp-close-dup.c |  3 +++
>  passt.c                                   |  3 +++
>  tap.c                                     |  4 +++-
>  udp_vu.c                                  |  7 +++++--
>  7 files changed, 20 insertions(+), 11 deletions(-)
> 
> -- 
> 2.52.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]