Re: [PATCH 5/7] doc/migration: Fix buffer type mismatch in recv() call

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

On Wed, Jul 08, 2026 at 06:32:01PM -0400, Jon Maloy wrote:
> The compound literal passed to recv() was int (4 bytes) but only
> 1 byte is received. Use int8_t to match the length, consistent with
> the other recv() calls in this file and in source.c.
> 
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>

Oops.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

Although, arguably to act as better documentation it should actually
check the value we get back from passt-repair.

> ---
>  doc/migration/target.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/migration/target.c b/doc/migration/target.c
> index 0eb1f6ac..78cfd564 100644
> --- a/doc/migration/target.c
> +++ b/doc/migration/target.c
> @@ -69,7 +69,7 @@ int main(int argc, char **argv)
>  	/* Send command to helper: turn repair mode on, wait for reply */
>  	cmd = TCP_REPAIR_ON;
>  	sendmsg(s_helper, &msg, 0);
> -	recv(s_helper, &((int){ 0 }), 1, 0);
> +	recv(s_helper, &((int8_t){ 0 }), 1, 0);
>  
>  	/* Set sending sequence */
>  	seq = TCP_SEND_QUEUE;
> -- 
> 2.52.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]