From: Ada Urbaniec <ada.urbaniec@gmail.com>
To: Anshu Kumari <anskuma@redhat.com>, passt-dev@passt.top
Subject: Fwd: [PATCH v3] tcp: Limit fast retransmit to one per loss event
Date: Sat, 21 Nov 2026 12:00:38 +0100 [thread overview]
Message-ID: <CAA7t2ySron57M4vP9wk+5LPc9BXi3xr5LmzjNjgqqCSxWkKxHQ@mail.gmail.com> (raw)
In-Reply-To: <CAA7t2yTP5oGNbyv4B3jt36buwTo2+_61OQoSRkE5m97xxdckzQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1918 bytes --]
Hi Stefano, Anshu,
Thanks! Yes, I would be happy to have a Reported-by tag. Happy to help!
I tested v3 as sent on my laptop, using source revision 6aa4f88 and Linux
7.0.0-43. I used an extended version of the reproducer I uploaded to bug
224 (attachment 73), with added periodic ACKs, delayed ACKs, zero-window
cases and retry timing measurements.
With both directions open, dropping the first data segment stops causing a
retransmission storm. If the segment remains missing, v3 retries after
about two seconds.
With a half-closed connection (the client sends FIN, then waits for the
response), v3 also stops the storm. Two cases still fail when the client
sends the same ACK every 10 ms:
* If the missing segment is never accepted, there is no further retry
during the four-second test.
* If the client starts accepting that segment after 100 ms, there is still
no retry, and the transfer does not complete within four seconds.
Without those repeated ACKs, the half-close recovery case completes after
about two seconds.
V3 stops the storm, but repeated ACKs can still prevent a half-closed
connection from retrying. The earlier patch with the timer fix does retry
under the same conditions.
On Fri, Nov 20, 2026 at 9:18 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> On Fri, 20 Nov 2026 23:07:56 +0530
> Anshu Kumari <anskuma@redhat.com> wrote:
>
> > Every duplicate ACK unconditionally triggered a fast retransmit,
> > even when the ACK sequence hadn't advanced.
> >
> > Guard fast retransmit on !conn->retries, and increment retries
> > after the first retransmit. This is a quick fix to stop the
> > amplification storm. Full compliance with RFC 5681 Section 3.2
> > (three duplicate ACKs) is left to a later patch.
>
> Ada, would you have a chance to try this patch out? Would you like to
> be credited with a Reported-by: tag?
>
> --
> Stefano
>
>
[-- Attachment #2: Type: text/html, Size: 2451 bytes --]
prev parent reply other threads:[~2026-11-21 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:37 Anshu Kumari
2026-11-20 19:48 ` Jon Maloy
2026-11-20 20:18 ` Stefano Brivio
[not found] ` <CAA7t2yTP5oGNbyv4B3jt36buwTo2+_61OQoSRkE5m97xxdckzQ@mail.gmail.com>
2026-11-21 11:00 ` Ada Urbaniec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA7t2ySron57M4vP9wk+5LPc9BXi3xr5LmzjNjgqqCSxWkKxHQ@mail.gmail.com \
--to=ada.urbaniec@gmail.com \
--cc=anskuma@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).