public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 0/8] splice() forwarding cleanups
Date: Fri, 05 Jun 2026 08:28:48 +0200 (CEST)	[thread overview]
Message-ID: <20260605082847.3f056af1@elisabeth> (raw)
In-Reply-To: <20260528050213.679685-1-david@gibson.dropbear.id.au>

On Thu, 28 May 2026 15:02:05 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> As we discussed on an earlier call, while fixing bug 202 I noticed a
> number of warts in the surrounding splice() forwarding code.  Most are
> just things that are longer or harder to follow than they need to be,
> but in some cases there may be real (if unlikely to trigger) bugs.
> Here's a collection of fixes.
> 
> David Gibson (8):
>   tcp_splice: Remove never-invoked SO_RCVLOWAT logic
>   tcp_splice: Simplify EPOLLRDHUP / eof / FIN handling
>   tcp_splice: Improve EOF exit condition for the loop
>   tcp_splice: Remove goto from forwarding loop
>   tcp_splice: Simplify shutdown(2) handling
>   tcp_splice: Simplify / correct OUT_WAIT flag handling
>   tcp_splice: Remove questionable "optimisation" of pending bytes
>     tracking

Applied up to here (7/8).

>   tcp_splice: Exit forwarding earlier when stalled read side
> 
>  tcp_splice.c | 100 ++++++++++++++++-----------------------------------
>  1 file changed, 31 insertions(+), 69 deletions(-)

-- 
Stefano


      parent reply	other threads:[~2026-06-05  6:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28  5:02 David Gibson
2026-05-28  5:02 ` [PATCH 1/8] tcp_splice: Remove never-invoked SO_RCVLOWAT logic David Gibson
2026-05-28  5:02 ` [PATCH 2/8] tcp_splice: Simplify EPOLLRDHUP / eof / FIN handling David Gibson
2026-05-28  5:02 ` [PATCH 3/8] tcp_splice: Improve EOF exit condition for the loop David Gibson
2026-05-28  5:02 ` [PATCH 4/8] tcp_splice: Remove goto from forwarding loop David Gibson
2026-05-28  5:02 ` [PATCH 5/8] tcp_splice: Simplify shutdown(2) handling David Gibson
2026-05-28  5:02 ` [PATCH 6/8] tcp_splice: Simplify / correct OUT_WAIT flag handling David Gibson
2026-06-04  4:41   ` Stefano Brivio
2026-06-04  5:14     ` David Gibson
2026-05-28  5:02 ` [PATCH 7/8] tcp_splice: Remove questionable "optimisation" of pending bytes tracking David Gibson
2026-06-04  4:41   ` Stefano Brivio
2026-06-04  5:14     ` David Gibson
2026-05-28  5:02 ` [PATCH 8/8] tcp_splice: Exit forwarding earlier when stalled read side David Gibson
2026-06-04  4:41   ` Stefano Brivio
2026-06-04  5:26     ` David Gibson
2026-06-04  5:44       ` Stefano Brivio
2026-06-04  7:08         ` David Gibson
2026-06-05  0:34   ` [PATCH v2 8/8] tcp_splice: Improve EOF and read stall exit conditions David Gibson
2026-06-05 10:59     ` Stefano Brivio
2026-06-05 16:26       ` David Gibson
2026-06-05  6:28 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260605082847.3f056af1@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).